Add endpoints to provide ability to modify logging verbosity #16111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
changed the title
ncabatoff
reviewed
Jun 22, 2022
ncabatoff
reviewed
Jun 22, 2022
ncabatoff
reviewed
Jun 22, 2022
ncabatoff
approved these changes
Jun 23, 2022
ncabatoff
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some endpoints to allow users to modify the logging verbosity of all loggers or an individual logger. One prerequisite of this is to ensure that the base logger that Vault uses is initialized using
IndependentLevelsso that individual loggers can be modified.The two endpoints that have been introduced are
sys/loggers(all loggers) andsys/loggers/:name(an individual logger, e.g.core). Each support aPOSTandDELETEto modify and revert back to Vault configuration, respectively.There were a handful of loggers that were not accounted for in
Core.allLoggersso I have added calls toCore.AddLoggerfor them. I performed an audit of calls tologger.Namedto ensure the ones that I did add made sense to track. There are many short-lived loggers which have been deliberately left out.This PR also includes a new doc page to outline the new endpoints.